Re: [PATCH 0/3] Introduce spgist quadtree @<(point,circle) operator

Hi!

On Fri, Feb 1, 2019 at 7:08 PM Matwey V. Kornilov
<matwey(dot)kornilov(at)gmail(dot)com> wrote:
> This patch series is to add support for spgist quadtree @<(point,circle)
> operator. The first two patches are to refactor existing code before
> implemention the new feature. The third commit is the actual implementation
> provided with a set of simple unit tests.

Cool!

> Matwey V. Kornilov (3):
> Introduce helper variable in spgquadtreeproc.c
> Introduce spg_quad_inner_consistent_box_helper() in spgquadtreeproc.c
> Add initial support for spgist quadtree @<(point,circle) operator

At first, I have to note that it's not necessary to post every patch
in separate message. It would be both easier and comfortable for
readers if you just put your patches as multiple attachments to the
same email message.

Regarding the patchset itself
* spg_quad_inner_consistent_circle_helper() definitely needs comments.
* In PostgreSQL we require that index scan produce exactly same
results as sequence scan. Can we ensure this is so for
@<(point,circle) operator even in corner cases of rounding error?
* In our coding style we have function name is the separate line from
its return type.

------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company