Re: pgsql: Implement jsonpath .datetime() method

On Thu, Sep 26, 2019 at 2:12 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru> writes:
> > I've noticed buildfarm is unhappy with my commits.
>
> The proximate problem seems to be that compareItems() is insufficiently
> careful to ensure that both values are non-null before passing them
> off to datatype-specific code. The code accidentally fails to crash
> on 64-bit machines, but it's still giving garbage answers, I think.

I've found compareItems() code to not apply appropriate cast to/from
Datum. Fixed in 7881bb14f4. This makes test pass on my local 32-bit
machine. I'll keep look on buildfarm.

It seems that caller (executePredicate()) don't NULL values to
compareItems(). It does do only for predicates, which doesn't have
right argument. But binary predicate with lacking argument should be
detected during syntactic analysis.

------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company