| From: | Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com>, Alexey Kondratov <a(dot)kondratov(at)postgrespro(dot)ru>, Liudmila Mantrova <l(dot)mantrova(at)postgrespro(dot)ru>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Andrey Borodin <x4mmm(at)yandex-team(dot)ru>, David Steele <david(at)pgmasters(dot)net>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, vladimirlesk(at)yandex-team(dot)ru, dsarafan(at)yandex-team(dot)ru |
| Subject: | Re: [Patch] pg_rewind: options to use restore_command from recovery.conf or command line |
| Date: | 2020-03-30 13:35:33 |
| Message-ID: | CAPpHfdu3Grv9EASN4D77Tms=M8smxSdmiN5gEcLPt07sksXD4w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Mar 30, 2020 at 4:57 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Fri, Mar 27, 2020 at 07:47:29AM +0900, Michael Paquier wrote:
> > On Thu, Mar 26, 2020 at 06:56:36PM -0300, Alvaro Herrera wrote:
> >> I don't think any such cleanup should hamper the patch at hand anyway.
> >
> > I don't think either, so I would do the split for the archive routines
> > at least. It still feels strange to me to have a different routine
> > name for the frontend-side of RestoreArchivedFile(). That's not
> > really consistent with the current practice we have palloc() & co, as
> > well as the sync routines.
>
> Okay. Hearing nothing, I have rebased the patch set this morning,
> improving some comments and the code format while on it. I would like
> to commit both 0001 (creation of xlogarchiver.h) and 0002 attached in
> the next couple of days. If you have an objection, please feel free.
I'm fine with patchset attached. Sorry for late reply.
------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Rémi Zara | 2020-03-30 13:42:59 | Re: pgsql: Add kqueue(2) support to the WaitEventSet API. |
| Previous Message | John Naylor | 2020-03-30 13:33:14 | tweaking perfect hash multipliers |