Re: Move PinBuffer and UnpinBuffer to atomics

From: Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>
To: Dilip Kumar <dilipbalaut(at)gmail(dot)com>
Cc: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, YUriy Zhuravlev <u(dot)zhuravlev(at)postgrespro(dot)ru>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Move PinBuffer and UnpinBuffer to atomics
Date: 2016-01-29 21:17:23
Message-ID: CAPpHfdu+bntYj2q=S4L1sR16q+5jD8Hmqun-6ZG-AThQdr118w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi, Dilip!

On Tue, Jan 19, 2016 at 6:00 PM, Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:

>
> On Tue, Jan 19, 2016 at 5:44 PM, Michael Paquier <
> michael(dot)paquier(at)gmail(dot)com> wrote:
>
>> > Test3:
>> > pgbench -i -s 100 postgres
>> > pgbench -c$ -j$ -Mprepared -S postgres
>> >
>> > Client Base Pached
>> >
>> > 1 20555 19404
>> > 32 375919 332670
>> > 64 509067 440680
>> > 128 431346 415121
>> > 256 380926 379176
>>
>> It seems like you did a copy-paste of the results with s=100 and
>> s=300. Both are showing the exact same numbers.
>
>
> Oops, my mistake, re-pasting the correct results for s=100
>
> pgbench -i -s 100 postgres
> pgbench -c$ -j$ -Mprepared -S postgres
>
> Client Base Pached
>
> 1 20548 20791
> 32 372633 355356
> 64 532052 552148
> 128 412755 478826
> 256 346701 372057
>

Could you please re-run these tests few times?
Just to be sure it's a reproducible regression with s=300 and not a
statistical error.

------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Merlin Moncure 2016-01-29 21:35:52 Re: Move PinBuffer and UnpinBuffer to atomics
Previous Message Pavel Stehule 2016-01-29 21:15:17 Re: [PATCH] better systemd integration