Re: Avoid full GIN index scan when possible

From: Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Nikita Glukhov <n(dot)gluhov(at)postgrespro(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Marc Cousin <cousinmarc(at)gmail(dot)com>
Subject: Re: Avoid full GIN index scan when possible
Date: 2020-01-11 00:10:05
Message-ID: CAPpHfdttREdy0H9ovJjcd5UUu1my6TS8GRNRuKpL2dTDt8o2wQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jan 10, 2020 at 7:36 PM Alexander Korotkov
<a(dot)korotkov(at)postgrespro(dot)ru> wrote:
>
> On Fri, Jan 10, 2020 at 6:31 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>
>> Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru> writes:
>> > So, I think v10 is a version of patch, which can be committed after
>> > some cleanup. And we can try doing better nulls handling in a separate
>> > patch.
>>
>> The cfbot reports that this doesn't pass regression testing.
>> I haven't looked into why not.
>
>
> Thank you for noticing. I'll take care of it.

In the v10 I've fixed a bug with nulls handling, but it appears that
test contained wrong expected result. I've modified this test so that
it directly compares sequential scan results with bitmap indexscan
results.

------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

Attachment Content-Type Size
0001-Avoid-GIN-full-scan-for-empty-ALL-keys-v11.patch application/octet-stream 28.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message nuko yokohama 2020-01-11 00:27:58 Re: Implementing Incremental View Maintenance
Previous Message Michael Paquier 2020-01-11 00:03:23 Re: Assert failure due to "drop schema pg_temp_3 cascade" for temporary tables and \d+ is not showing any info after drooping temp table schema