Re: GIN improvements part 1: additional information

From: Alexander Korotkov <aekorotkov(at)gmail(dot)com>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: GIN improvements part 1: additional information
Date: 2013-09-26 21:56:29
Message-ID: CAPpHfdtjtZCnmm334+eLB1844k8FWbwtSjvZbkfqa1HgzjWCEQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Sep 25, 2013 at 5:22 PM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:

> On 9/23/13 5:36 PM, Alexander Korotkov wrote:
> > In the attached version of patch double finding of ItemPointer during
> > insert is avoided. Overhead becomes lower as expected.
>
> Fails cpluspluscheck:
>
> ./src/include/access/gin_private.h: In function ‘char*
> ginDataPageLeafReadItemPointer(char*, ItemPointer)’:
> ./src/include/access/gin_private.h:797:2: warning: comparison between
> signed and unsigned integer expressions [-Wsign-compare]
>

Thanks. Fixed in attached version of patch.

------
With best regards,
Alexander Korotkov.

Attachment Content-Type Size
gin-packed-postinglists-7.patch.gz application/x-gzip 21.6 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2013-09-26 21:56:38 Re: [PATCH] pg_upgrade: Split off pg_fatal() from pg_log()
Previous Message Bruce Momjian 2013-09-26 21:50:08 Re: record identical operator - Review