Re: [PATCH]make pg_rewind to not copy useless WAL files

From: Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>
To: chenhj <chjischj(at)163(dot)com>
Cc: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH]make pg_rewind to not copy useless WAL files
Date: 2017-09-22 17:59:05
Message-ID: CAPpHfdt_Sos_-q3gdkgGB5KdaVQrH2h0mMMVd=ug2TheGGQg3g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Sep 22, 2017 at 7:16 PM, chenhj <chjischj(at)163(dot)com> wrote:

> This is the new pacth with TAP test and use Macro XLOGDIR.
>

Good. I took a quick look over the patch.
Why do you need master_query(), standby_query() and run_query() in
RewindTest.pm?
You can do just $node_master->safe_psql() and $node_slave->safe_psql()
instead.

------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2017-09-22 18:26:14 Re: Page Scan Mode in Hash Index
Previous Message Fabien COELHO 2017-09-22 17:55:12 Re: pgbench regression test failure