Re: pgsql: Fix bugs in RelationGetPartitionDispatchInfo.

From: Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>
To: Robert Haas <rhaas(at)postgresql(dot)org>
Cc: pgsql-committers <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: Fix bugs in RelationGetPartitionDispatchInfo.
Date: 2016-12-14 06:18:06
Message-ID: CAPpHfdtZTrKbQToTE2dPHx0nVkvC=CWCtbLDTph-vDSKthQTBw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Hmm, Dmitry Ivanov spotted this bug [1]. And he posted this patch with
only difference of variables naming and comments [2]. But he is not
mentioned in commit message. That doesn't look fine.

1.
https://www.postgresql.org/message-id/e6c56fe9-4b87-4f64-ac6f-bc99675f3f9e%40postgrespro.ru
2.
https://www.postgresql.org/message-id/0d5b64c9-fa05-4dab-93e7-56576d1193ca%40postgrespro.ru

------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

On Tue, Dec 13, 2016 at 7:32 PM, Robert Haas <rhaas(at)postgresql(dot)org> wrote:

> Fix bugs in RelationGetPartitionDispatchInfo.
>
> The previous coding was not quite right for cases involving multiple
> levels of partitioning.
>
> Amit Langote
>
> Branch
> ------
> master
>
> Details
> -------
> http://git.postgresql.org/pg/commitdiff/a25665088d812d08bb888e961f208e
> aebf522050
>
> Modified Files
> --------------
> src/backend/catalog/partition.c | 39 ++++++++++++++++++++++++++++++
> +++------
> 1 file changed, 33 insertions(+), 6 deletions(-)
>
>
> --
> Sent via pgsql-committers mailing list (pgsql-committers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-committers
>

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2016-12-14 06:47:24 Re: pgsql: Fix bugs in RelationGetPartitionDispatchInfo.
Previous Message Kevin Grittner 2016-12-14 01:20:27 pgsql: Back-patch fcff8a575198478023ada8a48e13b50f70054766 as a bug fix