| From: | Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Teodor Sigaev <teodor(at)sigaev(dot)ru>, pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgsql: Indexes with INCLUDE columns and their support in B-tree |
| Date: | 2018-04-08 15:53:33 |
| Message-ID: | CAPpHfdtRbE+mX9P5CYUQku=ogeVEW98SDSdiBq=4T4d36D-S_Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Sun, Apr 8, 2018 at 5:41 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Teodor Sigaev <teodor(at)sigaev(dot)ru> writes:
> > Indexes with INCLUDE columns and their support in B-tree
>
> The valgrind-using animals seem to think this broke stuff.
> There are at least two different problems here:
>
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=
> lousyjack&dt=2018-04-07%2020%3A03%3A02
I think attached patch should fix one of those problems.
We should match clauses to only key columns of index.
I will further investigate the problem with CheckIndexCompatible().
------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
| Attachment | Content-Type | Size |
|---|---|---|
| covering-fix-match-clause-to-indexcol.patch | application/octet-stream | 530 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Teodor Sigaev | 2018-04-08 16:30:52 | pgsql: Remove unused variable in non-assert-enabled build |
| Previous Message | Tom Lane | 2018-04-08 14:55:00 | pgsql: Add missing "static" markers. |