Re: Add SPLIT PARTITION/MERGE PARTITIONS commands

From: Alexander Korotkov <aekorotkov(at)gmail(dot)com>
To: Dmitry Koval <d(dot)koval(at)postgrespro(dot)ru>
Cc: Alexander Lakhin <exclusion(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Add SPLIT PARTITION/MERGE PARTITIONS commands
Date: 2024-04-19 13:29:44
Message-ID: CAPpHfdtLk5M4FV6C33DnBusWpsbwwmrQ83mpu7N8PZMupbftyw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Apr 19, 2024 at 2:26 AM Dmitry Koval <d(dot)koval(at)postgrespro(dot)ru> wrote:
>
> Hi!
>
> 18.04.2024 19:00, Alexander Lakhin wrote:
> > leaves a strange constraint:
> > \d+ t*
> > Table "public.tp_0"
> > ...
> > Not-null constraints:
> > "merge-16385-26BCB0-tmp_i_not_null" NOT NULL "i"
>
> Thanks!
> Attached fix (with test) for this case.
> The patch should be applied after patches
> v6-0001- ... .patch ... v6-0004- ... .patch

I've incorporated this fix with 0001 patch.

Also added to the patchset
005 – tab completion by Dagfinn [1]
006 – draft fix for table AM issue spotted by Alexander Lakhin [2]
007 – doc review by Justin [3]

I'm continuing work on this.

Links
1. https://www.postgresql.org/message-id/87plumiox2.fsf%40wibble.ilmari.org
2. https://www.postgresql.org/message-id/84ada05b-be5c-473e-6d1c-ebe5dd21b190%40gmail.com
3. https://www.postgresql.org/message-id/ZiGH0xc1lxJ71ZfB%40pryzbyj2023

------
Regards,
Alexander Korotkov

Attachment Content-Type Size
v7-0001-Change-the-way-ATExecMergePartitions-handles-the-.patch application/octet-stream 7.4 KB
v7-0002-Verify-persistence-of-new-partitions-during-MERGE.patch application/octet-stream 17.8 KB
v7-0005-Add-tab-completion-for-ALTER-TABLE-SPLIT-MERGE-PA.patch application/octet-stream 2.5 KB
v7-0003-Fix-error-message-in-check_partition_bounds_for_s.patch application/octet-stream 3.9 KB
v7-0004-Rename-tables-in-tests-of-partition-MERGE-SPLIT-o.patch application/octet-stream 202.8 KB
v7-0006-ALTER-TABLE-.-MERGE-PARTITIONS-.-make-inherit-par.patch application/octet-stream 1.6 KB
v7-0007-doc-review-for-ALTER-TABLE-.-SPLIT-MERGE-PARTITIO.patch application/octet-stream 6.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2024-04-19 13:55:55 Re: Direct SSL connection with ALPN and HBA rules
Previous Message Daniel Gustafsson 2024-04-19 13:17:10 Re: [PATCH] Avoid mixing custom and OpenSSL BIO functions