| From: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
|---|---|
| To: | Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com> |
| Cc: | Peter Geoghegan <pg(at)bowt(dot)ie>, Konstantin Knizhnik <knizhnik(at)garret(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Index range search optimization |
| Date: | 2023-09-25 10:18:04 |
| Message-ID: | CAPpHfdtAcD1Y5WRgFjos5SuZZE7WJwGRhSWtZ3RW3_3aYXhy6g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Sep 25, 2023 at 12:58 PM Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com> wrote:
> One more doubt about naming. Calling function
> _bt_checkkeys(IndexScanDesc scan, IndexTuple tuple, int tupnatts,
> ScanDirection dir, bool *continuescan, bool requiredMatchedByPrecheck)
> as
> (void) _bt_checkkeys(scan, itup, indnatts, dir,
> &requiredMatchedByPrecheck, false);
> looks little bit misleading because of coincidence of names of 5 and 6
> arguments.
I've added the comment clarifying this argument usage.
------
Regards,
Alexander Korotkov
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Skip-checking-of-scan-keys-required-for-direction-v6.patch | application/octet-stream | 10.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | jian he | 2023-09-25 10:52:03 | Re: [PATCH] Extend ALTER OPERATOR to support adding commutator, negator, hashes, and merges |
| Previous Message | torikoshia | 2023-09-25 10:13:35 | Re: Make --help output fit within 80 columns per line |