| From: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
|---|---|
| To: | Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com> |
| Cc: | Peter Geoghegan <pg(at)bowt(dot)ie>, Konstantin Knizhnik <knizhnik(at)garret(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Index range search optimization |
| Date: | 2023-09-27 16:41:31 |
| Message-ID: | CAPpHfdsLNP8wJBdmeWKSkLao7hpqdA_8qvMdkUpZtfgS1Aoffw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Sep 25, 2023 at 1:18 PM Alexander Korotkov <aekorotkov(at)gmail(dot)com>
wrote:
> On Mon, Sep 25, 2023 at 12:58 PM Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com>
> wrote:
> > One more doubt about naming. Calling function
> > _bt_checkkeys(IndexScanDesc scan, IndexTuple tuple, int tupnatts,
> > ScanDirection dir, bool *continuescan, bool requiredMatchedByPrecheck)
> > as
> > (void) _bt_checkkeys(scan, itup, indnatts, dir,
> > &requiredMatchedByPrecheck, false);
> > looks little bit misleading because of coincidence of names of 5 and 6
> > arguments.
>
> I've added the comment clarifying this argument usage.
>
Fixed typo inficating => indicating as pointed by Pavel.
Peter, what do you think about the current shape of the patch?
------
Regards,
Alexander Korotkov
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Skip-checking-of-scan-keys-required-for-direction-v7.patch | application/octet-stream | 10.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2023-09-27 16:42:03 | Re: Unlinking Parallel Hash Join inner batch files sooner |
| Previous Message | jacktby jacktby | 2023-09-27 16:37:41 | Set enable_seqscan doesn't take effect? |