| From: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
|---|---|
| To: | Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Melanie Plageman <melanieplageman(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Table AM Interface Enhancements |
| Date: | 2024-06-22 13:18:51 |
| Message-ID: | CAPpHfdtAbcbuc+tc_PWNkoAuPAk=cr__d87_D3DOyLr4_Tty8w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jun 21, 2024 at 7:37 PM Matthias van de Meent
<boekewurm+postgres(at)gmail(dot)com> wrote:
> On Tue, 16 Apr 2024 at 12:34, Alexander Korotkov <aekorotkov(at)gmail(dot)com> wrote:
> >
> > You're right. No sense trying to fix this. Reverted.
>
> I just noticed that this revert (commit 6377e12a) seems to have
> introduced two comment blocks atop TableAmRoutine's
> scan_analyze_next_block, and I can't find a clear reason why these are
> two separate comment blocks.
> Furthermore, both comment blocks seemingly talk about different
> implementations of a block-based analyze functionality, and I don't
> have the time to analyze which of these comments is authorative and
> which are misplaced or obsolete.
Thank you, I've just removed the first comment. It contains
heap-specific information and has been copied here from
heapam_scan_analyze_next_block().
------
Regards,
Alexander Korotkov
Supabase
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Melanie Plageman | 2024-06-22 14:42:50 | Re: FreezeLimit underflows in pg14 and 15 causing incorrect behavior in heap_prepare_freeze_tuple |
| Previous Message | Bruce Momjian | 2024-06-22 12:53:17 | Re: New standby_slot_names GUC in PG 17 |