Re: [PATCH] Incremental sort

From: Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>
To: Peter Geoghegan <pg(at)bowt(dot)ie>
Cc: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Mithun Cy <mithun(dot)cy(at)enterprisedb(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Incremental sort
Date: 2017-04-26 17:35:04
Message-ID: CAPpHfdt1BKqwY=s_1fC4r3Qa9R8jSnesJvnjTqjAC48r7Xjq2w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Apr 26, 2017 at 8:20 PM, Peter Geoghegan <pg(at)bowt(dot)ie> wrote:

> On Wed, Apr 26, 2017 at 10:10 AM, Alexander Korotkov
> <a(dot)korotkov(at)postgrespro(dot)ru> wrote:
> > OK, I get it. Our qsort is so fast not only on 100% presorted case.
> > However, that doesn't change many things in context of incremental sort.
>
> The important point is to make any presorted test case only ~99%
> presorted, so as to not give too much credit to the "high risk"
> presort check optimization.
>
> The switch to insertion sort that we left in (not the bad one removed
> by a3f0b3d -- the insertion sort that actually comes from the B&M
> paper) does "legitimately" make sorting faster with presorted cases.

I'm still focusing on making incremental sort not slower than qsort with
presorted optimization. Independently on whether this is "high risk"
optimization or not...
However, adding more test cases is always good.

------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Hunley, Douglas 2017-04-26 17:35:10 Re: RFC: ALTER SYSTEM [...] COMMENT
Previous Message Tom Lane 2017-04-26 17:31:42 Re: RFC: ALTER SYSTEM [...] COMMENT