Re: pgsql: Allow SIGINT to cancel psql database reconnections.

From: Alexander Korotkov <aekorotkov(at)gmail(dot)com>
To: Robert Haas <rhaas(at)postgresql(dot)org>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Allow SIGINT to cancel psql database reconnections.
Date: 2024-04-02 21:40:30
Message-ID: CAPpHfdt0KiF+QRZHidEgRKHeih4Z8aDeC6dMnqsDGwx1VP+gsA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Tue, Apr 2, 2024 at 5:30 PM Robert Haas <rhaas(at)postgresql(dot)org> wrote:
> Allow SIGINT to cancel psql database reconnections.
>
> After installing the SIGINT handler in psql, SIGINT can no longer cancel
> database reconnections. For instance, if the user starts a reconnection
> and then needs to do some form of interaction (ie psql is polling),
> there is no way to cancel the reconnection process currently.
>
> Use PQconnectStartParams() in order to insert a cancel_pressed check
> into the polling loop.
>
> Tristan Partin, reviewed by Gurjeet Singh, Heikki Linnakangas, Jelte
> Fennema-Nio, and me.
>
> Discussion: http://postgr.es/m/D08WWCPVHKHN.3QELIKZJ2D9RZ@neon.tech

This appears to have missing pgindent.
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=koel&dt=2024-04-02%2021%3A19%3A02

------
Regards,
Alexander Korotkov

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message David Rowley 2024-04-02 22:40:57 pgsql: Don't zero tuple_fraction when planning UNIONs with ORDER BYs
Previous Message Alexander Korotkov 2024-04-02 20:42:11 Re: pgsql: Implement pg_wal_replay_wait() stored procedure