Re: unnesting multirange data types

From: Alexander Korotkov <aekorotkov(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Zhihong Yu <zyu(at)yugabyte(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: unnesting multirange data types
Date: 2021-06-20 01:12:56
Message-ID: CAPpHfdsz-o7gYvByNF6pM7Yb7dbHzEN=Mx3BbsUc4SdRBFKrzQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Jun 19, 2021 at 7:35 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Alexander Korotkov <aekorotkov(at)gmail(dot)com> writes:
> > Patch successfully passed commitfest.cputube.org. I'm going to
> > re-push it if there are no objections.
>
> I'm still not happy about the way you've done the multirange-to-array
> part. I think we'd be better off improving the polymorphism rules so
> that that can be handled by one polymorphic function. Obviously that'd
> be a task for v15, but we've already concluded that just having the
> unnest ability would be minimally sufficient for v14.
>
> So I think you should trim it down to just the unnest part.

I'm not entirely sure it's worth introducing anyrangearray. There
might be not many use-cases of anyrangearray besides this cast
(normally one should use multirange instead of an array of ranges).
But I agree that this subject should be carefully considered for v15.

> In any case, beta2 wraps on Monday, and there is very little time
> left for a full round of buildfarm testing. I almost feel that
> it's too late to consider pushing this today. Tomorrow absolutely
> is too late for beta2.

+1
I also don't feel comfortable hurrying with unnest part to beta2.
According to the open items wiki page, there should be beta3. Does
unnest part have a chance for beta3?

------
Regards,
Alexander Korotkov

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2021-06-20 02:05:09 Re: unnesting multirange data types
Previous Message Noah Misch 2021-06-19 20:39:18 Re: Race between KeepFileRestoredFromArchive() and restartpoint