| From: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Alexander Korotkov <akorotkov(at)postgresql(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Detecting pointer misalignment (was Re: pgsql: Implementation of subscripting for jsonb) |
| Date: | 2021-02-12 01:36:02 |
| Message-ID: | CAPpHfdsn8cSQ96GMJa+Gk3acNKxBd83vu63fLFF+nynxGbArhQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Thu, Feb 11, 2021 at 9:46 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Alexander Korotkov <aekorotkov(at)gmail(dot)com> writes:
> > On Mon, Feb 8, 2021 at 7:49 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> >> Ugh, no it isn't: even pretty recent clang releases only define
> >> __GNUC__ as 4. It looks like we need a separate test on clang's
> >> version. I looked at their version history and sanitizers seem
> >> to have come in around clang 7, so I propose the attached (where
> >> I worked a bit harder on the comment, too).
>
> > Looks good to me. Thank you for revising!
>
> Were you going to push this, or did you expect me to?
Thank you for noticing. I'll commit this today.
------
Regards,
Alexander Korotkov
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2021-02-12 02:20:04 | pgsql: Allow multiple xacts during table sync in logical replication. |
| Previous Message | Peter Geoghegan | 2021-02-12 00:50:43 | pgsql: Remove obsolete IndexBulkDeleteResult stats field. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Greg Nancarrow | 2021-02-12 01:37:06 | Re: Libpq support to connect to standby server as priority |
| Previous Message | Ian Lawrence Barwick | 2021-02-12 01:32:14 | [DOC] add missing "[ NO ]" to various "DEPENDS ON" synopses |