Re: pgsql: Fix portability issue in new jsonbsubs code.

From: Alexander Korotkov <aekorotkov(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: Fix portability issue in new jsonbsubs code.
Date: 2021-02-01 10:35:01
Message-ID: CAPpHfdsn-WRQYp+ivSqsuEi4_mbbJsoi-78uGh8XfabLKR7agQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Mon, Feb 1, 2021 at 10:04 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Fix portability issue in new jsonbsubs code.
>
> On machines where sizeof(Datum) > sizeof(Oid) (that is, any 64-bit
> platform), the previous coding would compute a misaligned
> workspace->index pointer if nupper is odd. Architectures where
> misaligned access is a hard no-no would then fail. This appears
> to explain why thorntail is unhappy but other buildfarm members
> are not.

Thank you for fixing this!

------
Regards,
Alexander Korotkov

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Alexander Korotkov 2021-02-01 11:07:58 pgsql: Get rid of unnecessary memory allocation in jsonb_subscript_assi
Previous Message Michael Paquier 2021-02-01 10:23:07 pgsql: Introduce --with-ssl={openssl} as a configure option