Re: type cache cleanup improvements

From: Alexander Korotkov <aekorotkov(at)gmail(dot)com>
To: jian he <jian(dot)universality(at)gmail(dot)com>
Cc: Artur Zakirov <zaartur(at)gmail(dot)com>, Andrei Lepikhov <lepihov(at)gmail(dot)com>, Alexander Lakhin <exclusion(at)gmail(dot)com>, Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com>, Teodor Sigaev <teodor(at)sigaev(dot)ru>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>, Aleksander Alekseev <aleksander(at)timescale(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(at)paquier(dot)xyz>
Subject: Re: type cache cleanup improvements
Date: 2024-10-21 08:11:47
Message-ID: CAPpHfdsk+KfUTS2bUu+=eEJjPjz=mY_manKCYVMS6khvn_MStA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Oct 21, 2024 at 10:51 AM jian he <jian(dot)universality(at)gmail(dot)com> wrote:
>
> thanks for the
> INJECTION_POINT("typecache-before-rel-type-cache-insert");
> Now I have better understanding of the whole changes.
>
>
> +/*
> + * Add possibly missing RelIdToTypeId entries related to TypeCacheHas
> + * entries, marked as in-progress by lookup_type_cache(). It may happen
> + * in case of an error or interruption during the lookup_type_cache() call.
> + */
> +static void
> +finalize_in_progress_typentries(void)
> comment typo. "TypeCacheHas" should be "TypeCacheHash"

Thank you. This also has been spotted by Alexander Lakhin (off-list).
Fixed in the attached revision of the patchset.

------
Regards,
Alexander Korotkov
Supabase

Attachment Content-Type Size
v16-0001-Update-header-comment-for-lookup_type_cache.patch application/octet-stream 1.4 KB
v16-0002-Avoid-looping-over-all-type-cache-entries-in-Typ.patch application/octet-stream 24.7 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tender Wang 2024-10-21 08:30:45 Re: [BUG] Fix DETACH with FK pointing to a partitioned table fails
Previous Message Alexander Korotkov 2024-10-21 08:10:46 Re: type cache cleanup improvements