| From: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: post-freeze damage control |
| Date: | 2024-04-09 19:47:37 |
| Message-ID: | CAPpHfdshH90mDRriZABbS1sBFcjo4-uDJN3T9zB0G42pRSxiEQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Apr 9, 2024 at 5:12 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> * OrClauseGroupKey is not a Node type, so why does it have
> a NodeTag? I wonder what value will appear in that field,
> and what will happen if the struct is passed to any code
> that expects real Nodes.
I used that to put both not-subject-of-transform nodes together with
hash entries into the same list. This is used to save the order of
clauses. I think this is an important property, and I have already
expressed it in [1]. That could be achieved without adding NodeTag to
hash entries, but that would require a level of indirection. It's not
passed to code that expects real Nodes, it doesn't go to anything
except lists.
------
Regards,
Alexander Korotkov
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2024-04-09 19:53:46 | Re: simplehash.h: "SH_SCOPE static" causes warnings |
| Previous Message | Tom Lane | 2024-04-09 19:44:31 | Re: macOS Ventura won't generate core dumps |