Re: Should we cacheline align PGXACT?

From: Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>, Bernd Helmle <mailings(at)oopsware(dot)de>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Should we cacheline align PGXACT?
Date: 2017-02-17 09:23:28
Message-ID: CAPpHfdsca5=XpX+5e2SWoxKHgL_yf40yFN-BzVaPUZBUvSai9A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Feb 16, 2017 at 4:58 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:

> On Thu, Feb 16, 2017 at 5:07 AM, Alexander Korotkov
> <a(dot)korotkov(at)postgrespro(dot)ru> wrote:
> > On Wed, Feb 15, 2017 at 8:49 PM, Alvaro Herrera <
> alvherre(at)2ndquadrant(dot)com>
> > wrote:
> >> Alexander Korotkov wrote:
> >>
> >> > Difference between master, pgxact-align-2 and pgxact-align-3 doesn't
> >> > exceed
> >> > per run variation.
> >>
> >> FWIW this would be more visible if you added error bars to each data
> >> point. Should be simple enough in gnuplot ...
> >
> > Good point.
> > Please find graph of mean and errors in attachment.
>
> So ... no difference?

Yeah, nothing surprising. It's just another graph based on the same data.
I wonder how pgxact-align-3 would work on machine of Ashutosh Sharma,
because I observed regression there in write-heavy benchmark of
pgxact-align-2.

------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Khandekar 2017-02-17 09:26:49 Re: Parallel Append implementation
Previous Message Magnus Hagander 2017-02-17 08:54:37 Re: removing tsearch2