| From: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, Mikhail Gribkov <youzhick(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Greg Nancarrow <gregn4422(at)gmail(dot)com>, Ivan Panchenko <wao(at)mail(dot)ru>, Teodor Sigaev <teodor(at)sigaev(dot)ru>, Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Subject: | Re: On login trigger: take three |
| Date: | 2023-10-09 14:11:25 |
| Message-ID: | CAPpHfdsVgL6cb4a60oXH5aydXMVF5Z2sgBc1_MsobVibREJYAA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi!
On Tue, Oct 3, 2023 at 8:35 PM Alexander Korotkov <aekorotkov(at)gmail(dot)com> wrote:
> Thank you for the interesting ideas. I'd like to try to revive the
> version with the flag in pg_database. Will use other ideas as backup
> if no success.
I've revived the patch version with pg_database.dathasloginevt flag.
I took v32 version [1] and made the following changes.
* Incorporate enchantments made on flagless version of patch.
* Read dathasloginevt during InitPostgres() to prevent extra catalog
access and even more notable StartTransactionCommand() when there are
no login triggers.
* Hold lock during setting of pg_database.dathasloginevt flag (v32
version actually didn't prevent race condition).
* Fix AlterEventTrigger() to check event name not trigger name
* Acquire conditional lock while resetting pg_database.dathasloginevt
flag to prevent new database connection to hang waiting another
transaction to finish.
This version should be good and has no overhead. Any thoughts?
Daniel, could you please re-run the performance tests?
------
Regards,
Alexander Korotkov
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jelte Fennema | 2023-10-09 15:08:53 | Re: Request for comment on setting binary format output per session |
| Previous Message | Alexander Lakhin | 2023-10-09 14:00:00 | Re: A failure in 031_recovery_conflict.pl on Debian/s390x |