| From: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
|---|---|
| To: | Dmitry Dolgov <9erthalion6(at)gmail(dot)com> |
| Cc: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, David Steele <david(at)pgmasters(dot)net>, Nikita Glukhov <n(dot)gluhov(at)postgrespro(dot)ru>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, David Fetter <david(at)fetter(dot)org>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Oleksandr Shulgin <oleksandr(dot)shulgin(at)zalando(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Oleg Bartunov <obartunov(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] [PATCH] Generic type subscripting |
| Date: | 2020-11-27 09:13:48 |
| Message-ID: | CAPpHfdsP4xtDZfm2Ouat6vqf1U6gKMHiyW6gk6FPj35QDSq5kg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi!
I've started to review this patch. My first question is whether we're
able to handle different subscript types differently. For instance,
one day we could handle jsonpath subscripts for jsonb. And for sure,
jsonpath subscripts are expected to be handled differently from text
subscripts. I see we can distinguish types during in prepare and
validate functions. But it seems there is no type information in
fetch and assign functions. Should we add something like this to the
SubscriptingRefState for future usage?
Datum uppertypeoid[MAX_SUBSCRIPT_DEPTH];
Datum lowertypeoid[MAX_SUBSCRIPT_DEPTH];
------
Regards,
Alexander Korotkov
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Anastasia Lubennikova | 2020-11-27 09:19:20 | Re: Removing unneeded self joins |
| Previous Message | Drouvot, Bertrand | 2020-11-27 09:07:40 | Re: Add Information during standby recovery conflicts |