Re: SQL/JSON path: collation for comparisons, minor typos in docs

From: Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>
To: Markus Winand <markus(dot)winand(at)winand(dot)at>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: SQL/JSON path: collation for comparisons, minor typos in docs
Date: 2019-08-07 13:11:44
Message-ID: CAPpHfdsMP2RvdGdOFzHxd9s9+WoQ2YTv8yofD=OQGZUygn_gTw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi!

On Wed, Aug 7, 2019 at 2:25 PM Markus Winand <markus(dot)winand(at)winand(dot)at> wrote:
> I was playing around with JSON path quite a bit and might have found one case where the current implementation doesn’t follow the standard.
>
> The functionality in question are the comparison operators except ==. They use the database default collation rather then the standard-mandated "Unicode codepoint collation” (SQL-2:2016 9.39 General Rule 12 c iii 2 D, last sentence in first paragraph).

Thank you for pointing! Nikita is about to write a patch fixing that.

> I also found two minor typos in the docs. Patch attached.

Pushed, thanks.

> -markus
> ps.: I’ve created 230 test cases. Besides the WIP topic .datetime(), the collation issue is the only one I found. Excellent work. Down to the SQLSTATEs. For sure the most complete and correct SQL/JSON path implementation I've seen.

Thank you!

------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2019-08-07 13:24:22 Regression test failure in regression test temp.sql
Previous Message Sehrope Sarkuni 2019-08-07 12:56:18 Re: [Proposal] Table-level Transparent Data Encryption (TDE) and Key Management Service (KMS)