| From: | Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru> |
|---|---|
| To: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Re: proposal - psql: possibility to specify sort for describe commands, when size is printed |
| Date: | 2017-09-19 14:14:20 |
| Message-ID: | CAPpHfdsLq51crn2ome7y5TMEh-HQaXVaXeQ-xO2Xt9h8MQn7NQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Sep 8, 2017 at 7:13 AM, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
wrote:
> 2017-08-16 14:06 GMT+02:00 Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>:
>
>> Hi
>>
>> 2017-08-15 4:37 GMT+02:00 Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)
>> com>:
>>
>>> On 3/11/17 07:06, Pavel Stehule wrote:
>>> > I am sending a updated version with separated sort direction in special
>>> > variable
>>>
>>> This patch also needs a rebase.
>>>
>>
>> I am sending rebased patch
>>
>
> rebased again + fix obsolete help
>
For me, patch applies cleanly, builds and passed regression tests.
However, patch misses regression tests covering added functionality.
Patch is definitely harmless, i.e. it doesn't affect anybody who doesn't
use new functionality.
But I still would prefer ordering to be options of \d* commands while psql
variables be defaults for those options...
------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2017-09-19 14:22:52 | Re: [COMMITTERS] pgsql: Add citext_pattern_ops for citext contrib module |
| Previous Message | Robins Tharakan | 2017-09-19 14:07:00 | Re: psql - add ability to test whether a variable exists |