| From: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
|---|---|
| To: | Steve Chavez <steve(at)supabase(dot)io> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, nathandbossart(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Allow placeholders in ALTER ROLE w/o superuser |
| Date: | 2022-12-05 03:32:47 |
| Message-ID: | CAPpHfdsLd6E--epnGqXENqLP6dLwuNZrPMcNYb3wJ87WR7UBOQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Dec 1, 2022 at 6:14 AM Alexander Korotkov <aekorotkov(at)gmail(dot)com> wrote:
> On Wed, Nov 23, 2022 at 1:53 AM Steve Chavez <steve(at)supabase(dot)io> wrote:
> > So from my side this all looks good!
>
> Thank you for your feedback.
>
> The next revision of the patch is attached. It contains code
> improvements, comments and documentation. I'm going to also write
> sode tests. pg_db_role_setting doesn't seem to be well-covered with
> tests. I will probably need to write a new module into
> src/tests/modules to check now placeholders interacts with dynamically
> defined GUCs.
Another revision of patch is attached. It's fixed now that USER SET
values can't be used for PGC_SUSET parameters. Tests are added. That
require new module test_pg_db_role_setting to check dynamically
defined GUCs.
------
Regards,
Alexander Korotkov
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-USER-SET-parameters-for-pg_db_role_setting-v3.patch | application/octet-stream | 37.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dilip Kumar | 2022-12-05 03:51:10 | Re: Avoid streaming the transaction which are skipped (in corner cases) |
| Previous Message | Amit Kapila | 2022-12-05 03:29:45 | Re: Avoid streaming the transaction which are skipped (in corner cases) |