| From: | Miroslav Bendik <miroslav(dot)bendik(at)gmail(dot)com> |
|---|---|
| To: | Richard Guo <guofenglinux(at)gmail(dot)com> |
| Cc: | David Rowley <dgrowleyml(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Incremental sort for access method with ordered scan support (amcanorderbyop) |
| Date: | 2023-07-02 04:02:08 |
| Message-ID: | CAPoEpV2vgyQTJhmqVqdYSPRrjBNxM+qZ1Xxzepb0V-mCijBARg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Thanks, for suggestions.
On Sun 02. 07. 2023 at 10:18 Richard Guo <guofenglinux(at)gmail(dot)com> wrote:
> 1. For comment "On success, the result list is ordered by pathkeys.", I
> think it'd be more accurate if we say something like "On success, the
> result list is ordered by pathkeys or a prefix list of pathkeys."
> considering the possibility of incremental sort.
>
> 2. The comment below is not true anymore.
>
> /*
> * Note: for any failure to match, we just return NIL immediately.
> * There is no value in matching just some of the pathkeys.
> */
> We should either remove it or change it to emphasize that we may return
> a prefix of the pathkeys for incremental sort.
Comments are updated now.
> BTW, would you please add the patch to the CF to not lose track of it?
Submitted <https://commitfest.postgresql.org/43/4433/>
--
Best regards
Miroslav
| Attachment | Content-Type | Size |
|---|---|---|
| am_orderbyop_incremental_sort_v4.patch | text/x-patch | 5.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Noah Misch | 2023-07-02 05:45:31 | Re: Should CSV parsing be stricter about mid-field quotes? |
| Previous Message | jian he | 2023-07-02 02:38:20 | Re: Incremental View Maintenance, take 2 |