Re: Inherited UPDATE/DELETE vs async execution

From: Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com>
To: Amit Langote <amitlangote09(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Inherited UPDATE/DELETE vs async execution
Date: 2021-05-13 11:10:52
Message-ID: CAPmGK17kyyHHi73r8gXpxSLVUiSq0V1L=g5R98_eKCijfcfoLg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, May 13, 2021 at 5:00 PM Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> wrote:
>
> On Thu, May 13, 2021 at 3:32 PM Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
> > On Wed, May 12, 2021 at 6:45 PM Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> wrote:
> > > Here is a rebased version of the patch. I'm planning to apply this tommorow.
> >
> > + /*
> > + * Finally, unset the async-capable flag if it is set.
> > + */
> >
> > Would it make sense to expand here even just a bit on why we must do this?
>
> +1 How about something like this?
>
> "Finally, unset the async-capable flag if it is set, as we currently
> don't support asynchronous execution of direct modifications."

Pushed after modifying the comment as such. I think we could improve
it later. :-)

Thanks for the comment!

Will close this in the open items list.

Best regards,
Etsuro Fujita

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2021-05-13 11:11:19 Re: subscriptioncheck failure
Previous Message Michael Paquier 2021-05-13 11:06:18 Re: Executor code - found an instance of a WHILE that should just be an IF