| From: | Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
| Cc: | dacherny(at)gmail(dot)com, PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: BUG #16631: postgres_fdw tries to insert into generated columns |
| Date: | 2021-07-07 09:35:09 |
| Message-ID: | CAPmGK1732jc4iTfLg3K-6hwsedw4rt2j-BQ9n5tv+6nKUkySYw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Wed, Jul 7, 2021 at 5:45 PM Peter Eisentraut
<peter(dot)eisentraut(at)enterprisedb(dot)com> wrote:
> On 07.07.21 09:20, Etsuro Fujita wrote:
> > * Modified nodeModifyTable.c and copyfrom.c so that they don't compute
> > generated columns for FDWs anymore.
>
> I don't agree with that change. What is the point of declaring a
> generated column on a foreign table if you ignore it? Then you might as
> well prohibit declaring such columns in the first place.
I made that change as FDWs could call ExecComputeStoredGenerated() by
themselves if necessary. I think that that would be consistent with
the constraint case.
Best regards,
Etsuro Fujita
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2021-07-07 10:16:30 | Re: BUG #17089: "ERROR: invalid memory alloc request size ..." occurs when updating a fixed number of records |
| Previous Message | Peter Eisentraut | 2021-07-07 08:44:58 | Re: BUG #16631: postgres_fdw tries to insert into generated columns |