| From: | Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> |
|---|---|
| To: | Zhihong Yu <zyu(at)yugabyte(dot)com> |
| Cc: | Alexander Pyhalov <a(dot)pyhalov(at)postgrespro(dot)ru>, "Andrey V(dot) Lepikhov" <a(dot)lepikhov(at)postgrespro(dot)ru>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Defer selection of asynchronous subplans until the executor initialization stage |
| Date: | 2022-06-09 10:39:47 |
| Message-ID: | CAPmGK16s_N-r6tzPFqrAf1=gtNtN6B_3h8s9G-Y3sBPnLEjLOA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jun 8, 2022 at 7:18 PM Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> wrote:
> On Fri, Jun 3, 2022 at 1:03 AM Zhihong Yu <zyu(at)yugabyte(dot)com> wrote:
> > Suggestion on formatting the comment:
> >
> > + * node (or that for any plan node in the subplan tree), 2)
> > + * set_plan_references() modifies the tlist for every plan node in the
> >
> > It would be more readable if `2)` is put at the beginning of the second line above.
> >
> > + * preserves the length and order of the tlist, and 3) set_plan_references()
> > + * might delete the topmost plan node like an Append or MergeAppend from the
> >
> > Similarly you can move `3) set_plan_references()` to the beginning of the next line.
>
> Seems like a good idea, so I updated the patch as you suggest. I did
> some indentation as well, which I think improves readability a bit
> further. Attached is an updated version. If no objections, I’ll
> commit the patch.
Done.
Best regards,
Etsuro Fujita
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2022-06-09 11:02:20 | Re: Replica Identity check of partition table on subscriber |
| Previous Message | Michael Paquier | 2022-06-09 07:49:01 | Re: Improve TAP tests of pg_upgrade for cross-version tests |