From: | Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> |
---|---|
To: | Amit Langote <amitlangote09(at)gmail(dot)com> |
Cc: | Alexander Lakhin <exclusion(at)gmail(dot)com>, pgsql-bugs(at)lists(dot)postgresql(dot)org |
Subject: | Re: BUG #17355: Server crashes on ExecReScanForeignScan in postgres_fdw when accessing foreign partition |
Date: | 2022-02-03 06:32:24 |
Message-ID: | CAPmGK16hz0TTQ40Z-89_nONUsn-Q2v3xFO51P6N-q8Ogtq37jA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs |
Hi Amit-san,
On Wed, Feb 2, 2022 at 11:06 PM Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
> On Wed, Feb 2, 2022 at 7:55 PM Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> wrote:
> > On Wed, Feb 2, 2022 at 12:59 PM Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
> > > BTW, isn't the following code in ForeignNext() added by c3928b467
> > > non-reachable after your patch:
> > >
> > > /*
> > > * direct modifications cannot be re-evaluated, so shouldn't get here
> > > * during EvalPlanQual processing
> > > */
> > > if (estate->es_epq_active != NULL)
> > > elog(ERROR, "cannot re-evaluate a Foreign Update or Delete
> > > during EvalPlanQual");
> > >
> > > Should that be converted to an Assert(estate->es_epq_active == NULL)?
> >
> > +1 I updated the patch as such. Attached is a new version. I also
> > tweaked a comment a litttle bit further.
> Thanks, looks good to me.
Ok, I have committed the patch.
Thanks again!
Best regards,
Etsuro Fujita
From | Date | Subject | |
---|---|---|---|
Next Message | Etsuro Fujita | 2022-02-03 06:38:42 | Re: BUG #17355: Server crashes on ExecReScanForeignScan in postgres_fdw when accessing foreign partition |
Previous Message | Tom Lane | 2022-02-03 05:41:17 | Re: BUG #17391: While using --with-ssl=openssl and PG_TEST_EXTRA='ssl' options, SSL tests fail on OpenBSD 7.0 |