| From: | Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> |
|---|---|
| To: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Gilles Darold <gilles(at)darold(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH][DOC] Fix for PREPARE TRANSACTION doc and postgres_fdw message. |
| Date: | 2019-11-07 10:52:42 |
| Message-ID: | CAPmGK16_SxSMX=2MLCkv62tN29XbC4rrcQKWYLtp13smweT9Jw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Horiguchi-san,
On Thu, Nov 7, 2019 at 5:31 PM Kyotaro Horiguchi
<horikyota(dot)ntt(at)gmail(dot)com> wrote:
> I forgot to mention that the comment in XACT_EVENT_PRE_PREPARE
> contains the same mistake and needs more or less the same fix.
Good catch! How about rewriting "We disallow remote transactions that
modified anything" in the comment simply to "We disallow any remote
transactions" or something like that? Attached is an updated patch.
In the patch, I did s/prepare/PREPARE/ to the error message as well,
as you proposed.
Thanks again for reviewing!
Best regards,
Etsuro Fujita
| Attachment | Content-Type | Size |
|---|---|---|
| fix_postgres_fdw_prepared_transaction-v4.diff | application/octet-stream | 2.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2019-11-07 11:05:14 | Re: Using multiple extended statistics for estimates |
| Previous Message | Rafia Sabih | 2019-11-07 10:37:12 | Re: Parallel leader process info in EXPLAIN |