| From: | Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> |
|---|---|
| To: | Amit Langote <amitlangote09(at)gmail(dot)com> |
| Cc: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Shohei Mochizuki <shohei(dot)mochizuki(at)toshiba(dot)co(dot)jp>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: BEFORE UPDATE trigger on postgres_fdw table not work |
| Date: | 2019-06-12 07:30:26 |
| Message-ID: | CAPmGK16X4tt=S-J2gkVRZsH=Cz9AV0XRuZU2xzwx3Wj0_ET6Hg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Amit-san,
On Wed, Jun 12, 2019 at 3:33 PM Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
> On Wed, Jun 12, 2019 at 3:14 PM Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> wrote:
> > * Reworded the comments a bit in postgresPlanFoereignModify the
> > original patch modified
>
> + * statement, and for UPDATE if BEFORE ROW UPDATE triggers since those
> + * triggers might change values for non-target columns, in which case we
>
> First line seems to be missing a word or two. Maybe:
>
> + * statement, and for UPDATE if there are BEFORE ROW UPDATE triggers,
> + * since those triggers might change values for non-target columns, in
Actually, I omitted such words to shorten the comment, but I think
this improves the readability, so I'll update the comment that way.
Thanks for the review!
Best regards,
Etsuro Fujita
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Noah Misch | 2019-06-12 07:45:48 | Re: fix psql \conninfo & \connect when using hostaddr |
| Previous Message | Masahiko Sawada | 2019-06-12 07:28:35 | Re: [PATCH] Speedup truncates of relation forks |