postgres_fdw: misplaced? comments in connection.c

From: Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: postgres_fdw: misplaced? comments in connection.c
Date: 2021-10-11 08:05:58
Message-ID: CAPmGK164sAXQtC46mDFyu6d-T25Mzvh5qaRNkit06VMmecYnOA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

The comments for pgfdw_get_cleanup_result() say this:

* It's not a huge problem if we throw an ERROR here, but if we get into error
* recursion trouble, we'll end up slamming the connection shut, which will
* necessitate failing the entire toplevel transaction even if subtransactions
* were used. Try to use WARNING where we can.

But we don’t use WARNING anywhere in that function. The right place
for this is pgfdw_exec_cleanup_query()?

Best regards,
Etsuro Fujita

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2021-10-11 08:20:37 Re: Time to upgrade buildfarm coverage for some EOL'd OSes?
Previous Message houzj.fnst@fujitsu.com 2021-10-11 07:55:19 Drop replslot after pgstat_shutdown cause assert coredump