| From: | Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> |
|---|---|
| To: | amul sul <sulamul(at)gmail(dot)com> |
| Cc: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Rajkumar Raghuwanshi <rajkumar(dot)raghuwanshi(at)enterprisedb(dot)com>, Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Antonin Houska <ah(at)cybertec(dot)at>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] advanced partition matching algorithm for partition-wise join |
| Date: | 2019-07-30 07:57:55 |
| Message-ID: | CAPmGK158Rzfj7doxUuDF2_igRnsmm+X4gi+bLr73J8-pEghefg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jul 19, 2019 at 8:09 PM amul sul <sulamul(at)gmail(dot)com> wrote:
> On Mon, Jul 8, 2019 at 5:03 PM Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> wrote:
>> I started reviewing this. Here is my initial review comments:
>>
>> * 0001-Hash-partition-bound-equality-refactoring-v22.patch
>> However, I don't think it's a good idea to do this
>> refactoring, because that would lead to duplicating the code to check
>> whether two given hash bound collections are equal in
>> partition_bounds_equal() and partition_hash_bounds_merge() that will
>> be added by the main patch, after all. To avoid that, how about
>> calling partition_bounds_equal() from partition_hash_bounds_merge() in
>> the main patch, like the attached?
> Agree, your changes look good to me, thanks for working on it.
Cool! Thanks for reviewing!
Sorry for the delay. I was busy with something else recently.
Best regards,
Etsuro Fujita
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2019-07-30 08:02:20 | Re: POC: Cleaning up orphaned files using undo logs |
| Previous Message | Richard Guo | 2019-07-30 07:50:32 | Re: Parallel grouping sets |