Re: d25ea01275 and partitionwise join

From: Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com>
To: Amit Langote <amitlangote09(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: d25ea01275 and partitionwise join
Date: 2019-07-16 11:22:26
Message-ID: CAPmGK15+5RJS8cdPtQ25FBcwX5dLgtXFjkU1ZZ_0CRa6KqOzPw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jul 2, 2019 at 6:29 PM Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
> 0001 - fix partitionwise join to work correctly with n-way joins of
> which some are full joins (+ cosmetic improvements around the code
> that was touched)

Here are my comments about the cosmetic improvements: they seem pretty
large to me, so I'd make a separate patch for that. In addition, I'd
move have_partkey_equi_join() and match_expr_to_partition_keys() to
relnode.c, because these functions are only used in that file.

Best regards,
Etsuro Fujita

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dilip Kumar 2019-07-16 11:33:01 Re: POC: Cleaning up orphaned files using undo logs
Previous Message Sergei Kornilov 2019-07-16 11:19:43 Re: Change ereport level for QueuePartitionConstraintValidation