| From: | Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | postgres_fdw: Useless test in pgfdw_exec_cleanup_query_end() |
| Date: | 2024-03-22 12:30:09 |
| Message-ID: | CAPmGK14mm+=UjyjoWj_Hu7c+QqX-058RFfF+qOkcMZ_Nj52v-A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Another thing I noticed while working on [1] is $SUBJECT: this
function checks whether the given query string is non-NULL or not when
creating a WARNING message, but the function is always called with the
query string set, so it should be non-NULL. I removed the check and
instead added an assertion ensuring that the query string is non-NULL.
(I added the assertion to pgfdw_exec_cleanup_query_begin() as well.)
Attached is a patch for that.
If there are no objections, I will apply the patch to HEAD only.
Best regards,
Etsuro Fujita
| Attachment | Content-Type | Size |
|---|---|---|
| remove-useless-test-in-pgfdw_exec_cleanup_query_end.patch | application/octet-stream | 1.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2024-03-22 12:32:11 | Re: Introduce XID age and inactive timeout based replication slot invalidation |
| Previous Message | Ajin Cherian | 2024-03-22 12:24:43 | Re: Introduce XID age and inactive timeout based replication slot invalidation |