| From: | Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> |
|---|---|
| To: | Julien Rouhaud <rjuju123(at)gmail(dot)com> |
| Cc: | Amit Langote <amitlangote09(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Minor improvement to partition_bounds_copy() |
| Date: | 2020-02-21 11:06:31 |
| Message-ID: | CAPmGK14PGUHF39xw0z2ZiqeEZ=7pBBFAxXc5ionOuL7bmWw2_A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Feb 20, 2020 at 10:52 PM Julien Rouhaud <rjuju123(at)gmail(dot)com> wrote:
> On Thu, Feb 20, 2020 at 09:38:26PM +0900, Amit Langote wrote:
> > On Thu, Feb 20, 2020 at 8:36 PM Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> wrote:
> > > partition_bounds_copy() sets the hash_part and natts variable in each
> > > iteration of a loop to copy the datums in the datums array, which
> > > would not be efficient. Attached is small patch for avoiding that.
> >
> > That looks good to me.
>
> Looks good to me too!
Pushed. Thanks, Amit and Julien!
Best regards,
Etsuro Fujita
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ants Aasma | 2020-02-21 12:54:31 | Re: Parallel copy |
| Previous Message | Peter Eisentraut | 2020-02-21 09:09:38 | Re: backend type in log_line_prefix? |