| From: | Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> |
|---|---|
| To: | Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com> |
| Cc: | amul sul <sulamul(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Rajkumar Raghuwanshi <rajkumar(dot)raghuwanshi(at)enterprisedb(dot)com>, Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Antonin Houska <ah(at)cybertec(dot)at>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] advanced partition matching algorithm for partition-wise join |
| Date: | 2020-01-29 12:15:17 |
| Message-ID: | CAPmGK14H4UFcrDFDS-vviBptxD356YvnFZjdtR5cbELoK4_cKA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Mark,
On Tue, Jan 28, 2020 at 1:39 PM Mark Dilger
<mark(dot)dilger(at)enterprisedb(dot)com> wrote:
> There is stray whitespace in v30-0002:
>
> src/backend/partitioning/partbounds.c:4557: space before tab in indent.
> + outer_null_unmerged = true;
Good catch!
> I have added tests checking correctness and showing some partition pruning limitations. Find three patches, attached.
>
> The v31-0001-… patch merely applies your patches as a starting point for the next two patches. It is your work, not mine.
>
> The v31-0002-… patch adds more regression tests for range partitioning. The commit message contains my comments about that.
>
> The v31-0003-… patch adds more regression tests for list partitioning, and again, the commit message contains my comments about that.
The PWJ behavior shown by the tests you added looks interesting! I'll
dig into it more closely. Thanks for the patches and review!
Best regards,
Etsuro Fujita
| From | Date | Subject | |
|---|---|---|---|
| Next Message | 曾文旌 (义从) | 2020-01-29 13:06:44 | Re: [Proposal] Global temporary tables |
| Previous Message | Michael Paquier | 2020-01-29 11:38:52 | Re: Autovacuum on partitioned table |