| From: | Lucas Viecelli <lviecelli199(at)gmail(dot)com> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, David Fetter <david(at)fetter(dot)org>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: warning to publication created and wal_level is not set to logical |
| Date: | 2019-07-09 03:56:51 |
| Message-ID: | CAPjy-57VkFhHGLY2rtUNjBxN_GwcvbyfEh=bDCAMN3uJLNuV3g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Thomas.
Attached is the rebased
> The July Commitfest has started. This patch is in "Needs review"
> status, but it doesn't apply. If I read the above discussion
> correctly, it seems there is agreement that a warning here is a good
> idea to commit this patch. Could you please post a rebased patch?
>
>
I followed your suggestion and changed the message and added HINT. I hope
everything is agreed now.
> I wonder if it would be more typical project style to put the clue on
> what to do into an "errhint" message, something like this:
>
> WARNING: insufficient wal_level to publish logical changes
> HINT: Set wal_level to logical before creating subscriptions.
>
--
*Lucas Viecelli*
| Attachment | Content-Type | Size |
|---|---|---|
| warning-abount-wal_level-when-creating-publication.patch | text/x-patch | 5.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ryan Lambert | 2019-07-09 03:57:57 | Re: [Proposal] Table-level Transparent Data Encryption (TDE) and Key Management Service (KMS) |
| Previous Message | Bruce Momjian | 2019-07-09 03:35:28 | Re: [PATCH v4] Add \warn to psql |