Re: [Proposal] Level4 Warnings show many shadow vars

On Tue, Dec 10, 2019 at 5:21 AM Ranier Vilela <ranier_gyn(at)hotmail(dot)com>
wrote:

> New version the global patch, with the considerations.
> Unfortunately WalReceiverConn cannot be used because it is currently the
> typedef name for the structure.
> I switched to WalReceiverConnection, it was long but it looks good.
> RedoRecPtr proper name has no consensus yet, so it was still
> lastRedoRecPtr.
>
>
For someone that expounds consistency - this patch is the furthest thing
from it.

In some places names are randomly changed to have an underscore
(authmethodlocal to authmethod_local with the obvious inconsistency as
well) - in some places names are changed to remove underscores (stop_t to
stopt). Some places random letters are added (checkPoint to xcheckPoint)
some places perfectly good names are truncated (conf_file to file).

Random places remove perfectly good prefixes and replace with single
letters (numTables to nTables)

Random places switch from lower case names to upper case names (sentPtr to
WalSentPtr) most places leave lower case names (days to ndays).

Please at least be consistent within the patch itself.....

John W Higgins