Re: Obsolete TODO item "-Wcast-align" ?

From: Christian Convey <christian(dot)convey(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Obsolete TODO item "-Wcast-align" ?
Date: 2016-09-04 22:10:23
Message-ID: CAPfS4Zwa4s6gVGOO5x73KdfDUETx5Ch8Zx5eamQPgxFFRSNUxw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Sep 4, 2016 at 5:56 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Christian Convey <christian(dot)convey(at)gmail(dot)com> writes:
>> I chose this item from the TODO page: "[E] Remove warnings created by
>> -Wcast-align". It didn't have a check-mark after the "[E]", which I
>> took to mean it's an outstanding issue.
>> However, I'm starting to wonder if it's already been fixed:
>
> No, but you only see it on some platforms/compilers. On my OS X laptop
> (clang-based not gcc-based compiler), turning that on generates just a
> hair short of 13000 warnings :-(
>
> I think that TODO item is indeed obsolete, but more in the direction
> of "we're never gonna do that". There are too many places where we
> do need to cast up from generic pointer to specific structure pointer,
> and there doesn't seem to be any practical way to tell a compiler which
> instances are useful to warn about.

Thanks for the response. I'm unclear about how the TODO list is
curated. Is there someone whose attention I should direct to this
thread?

- Christian

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Greg Stark 2016-09-04 22:17:09 Re: pg_sequence catalog
Previous Message Tom Lane 2016-09-04 21:56:09 Re: Obsolete TODO item "-Wcast-align" ?