Re: dropdb --force

From: Filip Rembiałkowski <filip(dot)rembialkowski(at)gmail(dot)com>
To: Marti Raudsepp <marti(at)juffo(dot)org>
Cc: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: dropdb --force
Date: 2019-03-05 09:51:58
Message-ID: CAP_rwwn=v3dE05H3E06UFKR3JqLRnF_XLqbHgz7oH73Z3GxkKA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Here is Pavel's patch rebased to master branch, added the dropdb
--force option, a test case & documentation.

I'm willing to work on it if needed. What are possible bad things that
could happen here? Is the documentation clear enough?

Thanks.

On Tue, Dec 18, 2018 at 4:34 PM Marti Raudsepp <marti(at)juffo(dot)org> wrote:
>
> Hi
>
> > út 18. 12. 2018 v 16:11 odesílatel Filip Rembiałkowski <filip(dot)rembialkowski(at)gmail(dot)com> napsal:
> >> Please share opinions if this makes sense at all, and has any chance
> >> going upstream.
>
> Clearly since Pavel has another implementation of the same concept,
> there is some interest in this feature. :)
>
> On Tue, Dec 18, 2018 at 5:20 PM Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote:
> > Still one my customer use a patch that implement FORCE on SQL level. It is necessary under higher load when is not easy to synchronize clients.
>
> I think Filip's approach of setting pg_database.datallowconn='false'
> is pretty clever to avoid the synchronization problem. But it's also a
> good idea to expose this functionality via DROP DATABASE in SQL, like
> Pavel's patch, not just the 'dropdb' binary.
>
> If this is to be accepted into PostgreSQL core, I think the two
> approaches should be combined on the server side.
>
> Regards,
> Marti Raudsepp

Attachment Content-Type Size
drop-database-force-20190305_01.patch text/x-patch 14.1 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message amul sul 2019-03-05 10:14:32 Re: [HACKERS] advanced partition matching algorithm for partition-wise join
Previous Message Siarhei Siniak 2019-03-05 09:51:47 [Issue] Can't recompile cube extension as PGXS, utils/float.h is not installed