> Hmm, that seems like their problem not ours. It's not very clear
> to me why they'd want to force these flags from the compiler
> command line in the first place, but if they do they should be
> consistent with the more usual ways to set them.
There is no particular need to merge this patch for our sakes, as
the only reason it is this way was haste to build valgrind support.
Clang often finds some issue with the Postgres code style, so
I ignore its lint output, which is only regurgitated for errors anyway.
At least, in most build configurations. Happy to take any patches
for build stuff.