| From: | Krishnakumar R <kksrcv001(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org, byavuz81(at)gmail(dot)com, robertmhaas(at)gmail(dot)com |
| Subject: | Re: Add missing error codes to PANIC/FATAL error reports in xlogrecovery |
| Date: | 2023-12-04 09:07:22 |
| Message-ID: | CAPMWgZ_EtJjK=hutDqjBFTMjLoxumzKOkRAtdPNQJsr1ECXtig@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
Updated the patch with ERRCODE_CLUSTER_CORRUPTED & kept
ERRCODE_DATA_CORRUPTED when recovery is not consistent.
> > > Hm, this one arguably is not corruption, but we still cannot
> > > continue. ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE or maybe a new error code?
Added a ERRCODE_TIMELINE_INCONSISTENT to be specific about the
scenarios with timeline mismatches. Thoughts ?
>> Another aside: Isn't the hint here obsolete since we've removed exclusive
backups? I can't think of any scenario now where removing backup_label would
be correct in a non-exclusive backup.
Attached another patch which applies on top of the first patch to
remove the obsolete hint.
- KK
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Add-missing-error-codes-to-PANIC-FATAL-error-repo.patch | text/x-patch | 9.0 KB |
| v1-0001-Purge-error-hints-which-are-obsolete-due-to-the-r.patch | text/x-patch | 2.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | John Naylor | 2023-12-04 09:10:36 | Re: Add pg_basetype() function to obtain a DOMAIN base type |
| Previous Message | Richard Guo | 2023-12-04 08:42:02 | Re: A wrong comment about search_indexed_tlist_for_var |