Re: [pgAdmin4][Patch][RM_ 2477]: New Line text edit pop up renders off page when the size of the grid exceeds the size of the window

From: Shirley Wang <swang(at)pivotal(dot)io>
To: Robert Eckhardt <reckhardt(at)pivotal(dot)io>, Dave Page <dpage(at)pgadmin(dot)org>
Cc: Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch][RM_ 2477]: New Line text edit pop up renders off page when the size of the grid exceeds the size of the window
Date: 2017-06-12 16:55:07
Message-ID: CAPG3WN5HfL_-sgGRftiCeSLPdJ0TiqdyXuWaDmc3zzuU5O+Xsw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

>
>
>>
>> On Mon, Jun 12, 2017 at 2:27 PM, Surinder Kumar
>> <surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
>> > Hi
>> >
>> > The current font-family applied to slick-grid is
>> 'Verdana,Arial,sans-serif'.
>> > I tried changing it to "Helvetica Neue", Helvetica, Arial, sans-serif
>> but
>> > the font size and spacing between text is reduced. so to match style I
>> used
>> > "Verdana".
>> >
>> > Also, as per my knowledge, the Helvetica font will work only for
>> Operating
>> > Systems where this font actually exists in system, otherwise it will
>> pick
>> > Arial font.
>> >
>> > The right way to use 'Helvetica' is to download its 'ttf' and 'eot'
>> files
>> > and use in CSS so that it appears same on all machines:
>> >
>> https://stackoverflow.com/questions/13013616/css-helvetica-neue-not-working
>> >
>> > But it seems it is not available for free
>> > https://www.myfonts.com/fonts/linotype/neue-helvetica/licensing.html
>>
>> Oh, that's not good. I assume we were relying on it being on a users
>> machine already. I think we need to do one of two things:
>>
>> 1) Default to a font that we know should exist everywhere.
>> 2) Have a fallback from Helvetica Neue to Arial or similar.
>
> 3) Choose something completely new and free, and ship it with the app.
>>
>> I prefer 1 if possible, then 2, finally 3.
>>
>> Shirley, any thoughts?
>>
>
Option 1 would require us choosing something new and free (there are a lot
of webfonts you can get from Google) but would take some time to pick the
appropriate one.

Option 2 would be the best option for now. We should stick with Helvetica
and Arial until we have more time to choose the right font.

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Shruti B Iyer 2017-06-12 18:22:25 Re: [pgAdmin4] [PATCH] History Tab rewrite in React
Previous Message pgAdmin 4 Jenkins 2017-06-12 16:31:21 Build failed in Jenkins: pgadmin4-master-python35 #157