| From: | Shirley Wang <swang(at)pivotal(dot)io> |
|---|---|
| To: | Robert Eckhardt <reckhardt(at)pivotal(dot)io>, Dave Page <dpage(at)pgadmin(dot)org> |
| Cc: | Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>, Chethana Kumar <chethana(dot)kumar(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor |
| Date: | 2017-07-21 19:57:20 |
| Message-ID: | CAPG3WN4wXo-hdzBHiFWsZo_L6DCRvZ=sejJmf3VKYJELVN=03Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Until we learn definitively from users that the current implementation of
commenting/uncommenting in other tools is not working, we should use what
is common practice. We can use that as a baseline and then if we learn that
there needs to be another shortcut, we can add additional functionality.
It's much easier to add something for users than to take away.
On Fri, Jul 21, 2017 at 12:08 PM Robert Eckhardt <reckhardt(at)pivotal(dot)io>
wrote:
> Right - we lose the ability to uncomment multiple levels though, which may
>> also be useful.
>>
>
> Well yes.
>
> I would argue that simplicity trumps potential use. I'd also argue that
> attempting to maintain consistency across environments (IDEs, etc. ) is
> advantageous. This was the philosophy we were going with when enabling
> excel like behavior (also why I'm not fully happy with how it is today).
>
> -- Rob
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pawel Hadam | 2017-07-21 20:52:49 | Re: pgAdmin 4 v1.6 Released! |
| Previous Message | Surinder Kumar | 2017-07-21 19:33:00 | Re: [pgAdmin4]: Webpacking of static JS/CSS |