Re: Autoformatting

Hello!

We're starting development on this soon, so pulling this thread back up.

Here is an update on the design of the pop up, which matches the style we
decided for alerts.
[image: autoformating-bluepopup.png]
[image: formatted query.png]

On Fri, Feb 17, 2017 at 4:32 AM Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Hi
>
> On Thu, Feb 16, 2017 at 5:19 PM, Shirley Wang <swang(at)pivotal(dot)io> wrote:
>
>> Hello!
>>
>> Attached are current designs for SQL autoformatting. This feature is not
>> developed yet, only mockups of a potential solution so technical
>> implementation is still being discussed. Style guide for autoformatting
>> doesn't yet exist either, what's shown is manually formatted by another
>> person.
>>
>> When a user highlights a section of text, a menu option appears below
>> with the option to autoformat text.
>>
>> Not included in this current design:
>> - other options available when highlighting multiple sections of text
>>
>
> Per our discussion yesterday, I think this is my biggest concern. Other
> examples of options when blocks of text are highlighted are block
> indent/outdent (we already have indent), and block commenting.
>

I think these can be added in the future, but for now, we should focus on
this one and establish a precedent for shortcut pop ups. It will be easier
for contributors to add other options with this styling later when they
want to, plus we'll get some additional validation that this
location/color/copy works.

>
>
>> - compacting queries
>>
>> We're currently testing this design with pgAdmin3 users. Looking to
>> validate with a few more before developing the feature. Let us know your
>> thoughts!
>>
>
> I have a couple more:
>
> - I think the popup control panel should be in a different colour to the
> highlight color. Maybe the light blue we use on the bootstrap panels.
>
> - Please ensure the formatting code is a implemented in a way that allows
> easy re-use. I'd like to be able to use it on the SQL and mSQL panels for
> example, to ensure consistent formatting for display which can be very hard
> to achieve in the templates alone.
>
> - I would suggest starting a mailing list thread with a rough draft of the
> intended formatting rules. We can refine them together, and include them in
> the docs as well as implemented in the code.
>
>
Yes! We'll do that.