Re: PGAgent 4.0 error feedback

From: Rob Emery <re-pgsql(at)codeweavers(dot)net>
To: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: PGAgent 4.0 error feedback
Date: 2018-06-11 07:20:19
Message-ID: CAPCETptE0Ug_qVe6nUOpktQ1MbQSrsR50sRR-ixCW9qa82VMrA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Ashesh,

Log-level wise I was using the same command for both versions:

./pgagent -f -l 2 -t 1 -r 1 'hostaddr=server user=username
password=password dbname=postgres'

and messing up the connection string in various ways (missing dbname,
incorrect password, incorrect hostaddr)

This was built and tested on Debian GNU/Linux 9.4 (stretch).

I've attached an example of the differing output when the dbname is missing
from the connectionstring; basically it's the same for all errors.

Many Thanks,
Rob

On 11/06/2018, Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
> Hi Rob,
>
> On Sun, Jun 10, 2018 at 2:26 AM, Rob Emery <re-pgsql(at)codeweavers(dot)net>
> wrote:
>
>> Hi Guys,
>>
>> I've been testing out PGAgent 4 (build today from master at commit
>> 86ca5c5ed1ad572075ba27e05e4680ebdf5b9feb) to check the connection
>> handling on error is still fixed with the boost reimplementation
>> (which it is!)
>> and noticed a few issues compared to PGAgent 3 around feedback to the
>> user if the connection string is incorrect.
>>
>> I've tested with incorrect username and password, user not in the hba,
>> db doesn't exist, postgresql not running on the host (or incorrect
>> hostaddr) and 4 seems to always returns the error :
>> `
>> ERROR: Couldn't find the function 'pgagent_schema_version' - please
>> run pgagent_upgrade.sql.
>> `
>>
>> whereas 3.4.1 tends to output from the pgconnection itself like:
>> `
>> Sat Jun 9 21:32:13 2018 : WARNING: Couldn't create the primary
>> connection (attempt 1): FATAL: no pg_hba.conf entry for host
>> "172.30.0.16", user "pgagent_login_role", database
>> "pgagent_login_role", SSL on
>> FATAL: no pg_hba.conf entry for host "172.30.0.16", user
>> "pgagent_login_role", database "pgagent_login_role", SSL off
>> `
>>
>> which at least points the user towards the actual error!
>>
>> Not sure if this is known already, but I thought I'd raise it prior to
>> release.
>>
> Thanks for sharing the information.
>
> Is it possible for you to share the logs with log level set to debug?
> Also - please share the operating system details?
>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> <http://www.enterprisedb.com/>
>
>
> *http://www.linkedin.com/in/asheshvashi*
> <http://www.linkedin.com/in/asheshvashi>
>
>
>
>>
>> Thanks,
>> Rob
>> --
>>
>> --
>> <https://codeweavers.net>
>>
>>
>> Codeweavers May Newsletter
>> <https://mailchi.mp/codeweavers/march-edition-336883> l Codeweavers
>> April
>> Finance Trends
>> <https://codeweavers.net/company-blog/codeweavers-april-finance-trends>
>>
>>
>> April’s Dealer Highlights
>> <https://codeweavers.net/company-blog/aprils-dealer-highlights>
>> <https://codeweavers.net/company-blog/codeweavers-march-car-finance-trends
>> >
>>
>> _
>> _
>>
>>
>>
>> *Phone:* 0800 021 0888 Email: contactus(at)codeweavers(dot)net
>> <mailto:contactus(at)codeweavers(dot)net>
>> Codeweavers Ltd | Barn 4 | Dunston
>> Business Village | Dunston | ST18 9AB
>> Registered in England and Wales No.
>> 04092394 | VAT registration no. 974 9705 63
>>
>>
>>
>>
>> <https://www.linkedin.com/company/codeweavers-limited>
>> <https://vimeo.com/codeweaversltd>
>> <https://plus.google.com/b/105942302039373248738/+CodeweaversNet>
>> <https://twitter.com/CodeweaversTeam>
>>
>>
>>
>

--
<https://codeweavers.net>

Codeweavers May Newsletter
<https://mailchi.mp/codeweavers/march-edition-336883>  l  Codeweavers April
Finance Trends
<https://codeweavers.net/company-blog/codeweavers-april-finance-trends>

April’s Dealer Highlights
<https://codeweavers.net/company-blog/aprils-dealer-highlights>
<https://codeweavers.net/company-blog/codeweavers-march-car-finance-trends>

_
_

*Phone:* 0800 021 0888   Email: contactus(at)codeweavers(dot)net
<mailto:contactus(at)codeweavers(dot)net>
Codeweavers Ltd | Barn 4 | Dunston
Business Village | Dunston | ST18 9AB
Registered in England and Wales No.
04092394 | VAT registration no. 974 9705 63 


<https://www.linkedin.com/company/codeweavers-limited>  
<https://vimeo.com/codeweaversltd>  
<https://plus.google.com/b/105942302039373248738/+CodeweaversNet>  
<https://twitter.com/CodeweaversTeam>

Attachment Content-Type Size
PGagent-BrokenConnectionString.txt text/plain 587 bytes

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Ashesh Vashi 2018-06-11 07:28:51 Re: PGAgent 4.0 error feedback
Previous Message Aditya Toshniwal 2018-06-11 05:44:44 Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree