| From: | Kasahara Tatsuhito <kasahara(dot)tatsuhito(at)gmail(dot)com> |
|---|---|
| To: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Cc: | Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Tid scan increments value of pg_stat_all_tables.seq_scan. (but not seq_tup_read) |
| Date: | 2020-02-07 06:07:51 |
| Message-ID: | CAP0=ZV+3eoTk7hYtRC0eE9cftXkC+HHzZ-YFdO+g2gRhjRwBHA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Fri, Feb 7, 2020 at 1:27 PM Kyotaro Horiguchi
<horikyota(dot)ntt(at)gmail(dot)com> wrote:
> It seems that nkeys and key are useless. Since every table_beginscan_*
> functions have distinct parameter sets, don't we remove them from
> table_beginscan_tid?
Yeah, actually, when calling table_beginscan_tid(), nkeys is set to 0
and * key is set to NULL,
so these are not used at the moment.
I removed unnecessary arguments from table_beginscan_tid().
Attache the v5 patch.
--
Tatsuhito Kasahara
kasahara.tatsuhito _at_ gmail.com
| Attachment | Content-Type | Size |
|---|---|---|
| fix_tidscan_issues_v5.patch | application/octet-stream | 3.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2020-02-07 06:28:59 | Re: WIP: expression evaluation improvements |
| Previous Message | Kyotaro Horiguchi | 2020-02-07 04:26:15 | Re: Tid scan increments value of pg_stat_all_tables.seq_scan. (but not seq_tup_read) |